<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 22/02/2013 17:23, Mike Brudenell
wrote:<br>
</div>
<blockquote
cite="mid:CAPXCWas22oLBNzYVG_j2cNh8jTK1559S0bG2UYFqd5gcRcN-+g@mail.gmail.com"
type="cite">
<div dir="ltr">Greetings -
<div><br>
</div>
<div>There are a number of small but annoying problems with the
content of templates/dropoff_email.tpl file that I've been
wrestling into submission.</div>
<div><br>
</div>
<div>Most stem from stray spaces at the end of lines. Sounds
daft I know, but the message is composed and sent as
"format-flowed", which tells the recipient's email program to
look for any lines ending "space<CR><LF>" and join
them with the next then reflow the result.</div>
<div><br>
</div>
<div>This means that some on the lines of the dropoff email join
onto previous ones and look weird.</div>
<div><br>
</div>
<div>To fix edit the standard config/dropoff_email.tpl as
follows:</div>
<div>
<ul style="">
<li style="">Line 2: (after the line beginning "This is an…"<br>
Delete all the spaces that are present on this
meant-to-be-blank line.<br>
</li>
</ul>
</div>
</div>
</blockquote>
Done. Will be in the next release.<br>
<blockquote
cite="mid:CAPXCWas22oLBNzYVG_j2cNh8jTK1559S0bG2UYFqd5gcRcN-+g@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<ul style="">
<li style=""><br>
</li>
<li style="">Line 9:<br>
Says "If you wish to contact the sender, just reply to
this email." but our messages get sent out from a
"do-not-reply" address as set with EmailSenderAddress in
conf/zendto.conf. I think I read recently that ZendTo no
longer forges the sender's email address for messages it
sends out, so presumably this statement should no longer
be present?<br>
</li>
</ul>
</div>
</div>
</blockquote>
No, if you check an email sent by it, it should be setting the
"Reply-To:" header which overrides the "From:" address when a
recipient thumps "Reply".<br>
<blockquote
cite="mid:CAPXCWas22oLBNzYVG_j2cNh8jTK1559S0bG2UYFqd5gcRcN-+g@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<ul style="">
<li style="">
<br>
</li>
<li style="">Line 27: (the one before the line beginning "--
File…"<br>
Delete all the spaces that are present on this
meant-to-be-blank line.<br>
</li>
</ul>
</div>
</div>
</blockquote>
Done. Will be in the next release.<br>
<blockquote
cite="mid:CAPXCWas22oLBNzYVG_j2cNh8jTK1559S0bG2UYFqd5gcRcN-+g@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<ul style="">
<li style=""><br>
</li>
<li style="">Line 31: (The "Description" of a file)<br>
When no description text is entered then this leaves the
message's line ending with "space<CR><LF>",
which causes the next line (Size) to be joined to the
Description line and reflowed. A (not ideal) fix is to
change<br>
Description: {$f.description}<br>
to<br>
Description: {if $f.description ne
""}"{$f.description}"{else}(None){/if}.<br>
<br>
Note: the final ".", seems to be needed to stop the parser
from swallowing the newline after the "{/if}" and joining
with the next line anyway.</li>
</ul>
<div style="">I wish I could improve on the final edit to
avoid the need for the final "." but I'm not familiar enough
with the idiosyncrasies of whatever parses the templates.
Any offers…? :-)</div>
</div>
</div>
</blockquote>
I'll take a look at this. From a quick bit of Googling, it appears
to be a bit of a known problem in Smarty, as it was designed to
handle HTML files primarily, and has a rule that if the Smart code
in {} produced some output, the following whitespace is left alone,
but if it produced no output then it is swallowed.<br>
"tags that don't have output swallow a following newline but tags
that have output keep it." from<br>
<a class="moz-txt-link-freetext" href="http://www.smarty.net/forums/viewtopic.php?p=12960">http://www.smarty.net/forums/viewtopic.php?p=12960</a><br>
<br>
The better way would be to replace the value of $f.description in
the PHP code with the string "(None)" and allow you to insert
translations as necessary. i.e. make it a zendto.conf string.<br>
<br>
Sound good?<br>
<br>
Jules.<br>
<br>
<blockquote
cite="mid:CAPXCWas22oLBNzYVG_j2cNh8jTK1559S0bG2UYFqd5gcRcN-+g@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div style="">
<br>
</div>
<div style="">Cheers,</div>
<div style="">Mike B-)</div>
<div style=""><br>
</div>
-- <br>
<font size="1"><font face="'arial narrow', sans-serif"><span
style="font-size:small">IT Services, The University of
York, Heslington, York YO10 5DD, UK<br>
Tel: +44-1904-323811</span><span style="font-size:small"><br>
Disclaimer: <</span><a moz-do-not-send="true"
href="http://www.york.ac.uk/docs/disclaimer/email.htm"
target="_blank"><span style="font-size:small">http://www.york.ac.uk/docs/disclaimer/email.htm</span></a><span
style="font-size:small">></span></font><br>
</font>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
ZendTo mailing list
<a class="moz-txt-link-abbreviated" href="mailto:ZendTo@zend.to">ZendTo@zend.to</a>
<a class="moz-txt-link-freetext" href="http://mailman.ecs.soton.ac.uk/mailman/listinfo/zendto">http://mailman.ecs.soton.ac.uk/mailman/listinfo/zendto</a></pre>
<br>
<pre class="moz-signature" cols="72">Jules
--
Julian Field MEng MBCS CITP CEng
'Science is an integral part of culture. It's not this foreign
thing, done by an arcane priesthood. It's one of the glories of
human intellectual tradition.' - Stephen Jay Gould
<a class="moz-txt-link-abbreviated" href="http://www.Zend.To">www.Zend.To</a>
Twitter: @JulesFM
PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654
</pre>
</blockquote>
</body>
</html>