<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
</head>
<body bgcolor="#ffffff" text="#000000">
Dear jules,<br>
i've found these ??bugs??:<br>
<br>
lib/NSSDropoff.php: line 1343 $smarty->assign('fileCount',
$readFileCount);<br>
readFileCount does not exists anywhere: it's a duplicate of
realFilecount ??? line to be removed<br>
<br>
lib/NSSDropoff.php: line 1343 while ( $i < $fileCount ) {<br>
I believe it's correct use $i strictly < of $fileCount; this
potential error is repeated along the code in 1193/1251<br>
<br>
www/Verify.php: line 55 if ($resp->is_valid && (
$theVerify = new Verify($theDropbox) )) {<br>
The logical AND is && and must be used when almost one of the
ops is not an integer.<br>
<br>
www/Verify.php: line 122 $theDropbox->writeToLog("Public
key=".$reCaptchaPublicKey);<br>
useless log line: who care of it ?<br>
<br>
And two suggestion: the site policy could be more clear if present in
every page.<br>
I've added in NSSDropoff below line 744 these 3<br>
<blockquote type="cite"> $smarty->assign('maxBytesForFile',
NSSFormattedMemSize($this->_maxBytesForFile));<br>
$smarty->assign('maxBytesForDropoff',
NSSFormattedMemSize($this->_maxBytesForDropoff));<br>
$smarty->assign('retainDays', $this->_retainDays);</blockquote>
<br>
and added into header.tpl below line 53 as follow:<br>
<blockquote type="cite"> <tr><br>
<td id="prefs" align=right colspan=2><br>
<BR>MAX single attachment size: {$maxBytesForFile}
&nbsp; &nbsp; &nbsp;<br>
<BR>MAX total attachment size: {$maxBytesForDropoff}
&nbsp; &nbsp; &nbsp;<br>
<BR>Attachment Retain time: {$retainDays} &nbsp;
&nbsp; &nbsp;<br>
</td><br>
</tr><br>
</blockquote>
So in every page is printed-out the site policy (max bytes .. and
retain time).<br>
<br>
Another change is into the single dropoff view, where is printed-out
the creation date, but i believe it's more important to know when the
dropoff will expire.<br>
So I changed the NSSDropoff.php adding below line 790:<br>
global $prefs;<br>
<br>
and below line 852:<br>
<br>
$smarty->assign('expiration',strftime("%d %b
%Y&nbsp;&nbsp;%r",timeForDate($this->created())+3600*24*$prefs['numberOfDaysToRetain']));<br>
<br>
<br>
and changed into the show_dropoff.tpl, lines from 72-75 to<br>
<blockquote type="cite"> <tr><br>
<td class="UD_form_lined" align="right"><b>Will
Expire On:</b></td><br>
<td><tt>{$expiration}</tt></td><br>
</tr><br>
</blockquote>
<br>
Bye.<br>
<div class="moz-signature">-- <br>
<center><span
style="font-family: Verdana,sans-serif; font-weight: bold;">
Ing. Sergio Rabellino<br>
</span>
<br>
<span style="font-family: Verdana,sans-serif;">
Universitą degli Studi di Torino<br>
Dipartimento di Informatica<br>
ICT Services Director<br>
Tel +39-0116706701
Fax +39-011751603<br>
C.so Svizzera , 185 - 10149 - Torino<br>
<br>
<a href="http://www.di.unito.it" alt="Dipartimento di Informatica"><img
src="cid:part1.05060501.00060600@di.unito.it" border="0"></a>
</span></center>
</div>
</body>
</html>