<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
pre
{mso-style-priority:99;
mso-style-link:"Préformaté HTML Car";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.PrformatHTMLCar
{mso-style-name:"Préformaté HTML Car";
mso-style-priority:99;
mso-style-link:"Préformaté HTML";
font-family:Consolas;
mso-fareast-language:EN-US;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="FR-CA" link="#0563C1" vlink="#954F72">
<div style="padding-bottom: 10px; padding-top: 5px;">
<div style="padding:12px; border:1px solid #8D3970; background-color:#F7F9FA; color:#8D3970; font-size:14px; line-height:22px; font-family: Calibri, Arial, Helvetica, sans-serif;">
<strong>CAUTION:</strong> This e-mail originated outside the University of Southampton.
</div>
</div>
<div>
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Hi David,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">The patch does the job, everything works fine now<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">I do not have a recent version of CGI::Cookie Perl package installed.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thank you,<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="FR" style="mso-fareast-language:FR-CA">MarioDe :</span></b><span lang="FR" style="mso-fareast-language:FR-CA"> eprints-tech-bounces@ecs.soton.ac.uk <eprints-tech-bounces@ecs.soton.ac.uk>
<b>De la part de</b> David R Newman via Eprints-tech<br>
<b>Envoyé :</b> 2 juin 2021 13:36<br>
<b>À :</b> Beaudoin, Mario via Eprints-tech <eprints-tech@ecs.soton.ac.uk><br>
<b>Objet :</b> Re: [EP-tech] set_lang on 3.4.3<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Hi Mario,<o:p></o:p></p>
<p>This code relates to setting the correct attributes for the cookie EPrints uses to store the user's language preference. This change was made to deal with the fact that FireFox was not going to continue to support the cookei for this in its current form.
<o:p></o:p></p>
<p><a href="https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints3.4%2Fissues%2F118&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C5acd4f71cb754b1ad07608d92779f976%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637584227089335477%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=nX2X%2BcYIbCGZ90jXvuOn2bDQ6gUmdRjv7AvGe4Fkauc%3D&reserved=0" originalSrc="https://github.com/eprints/eprints3.4/issues/118" shash="VwvwCjQ14LD5QI+nFbKq3/7XW/RniKD7yss0mf9lw+zyVg0S8VxUHL++4GRTZHfj2osiq0qe18QnPQQLlcnjHl5zgkDwlF/WNZMPAor3xCGct0F5F8H7zaq1OlYBWqxAt2uebZU/4RlhdCCO+JLcEvzeffRgkNoJT4oFk4U5ZXM=">https://github.com/eprints/eprints3.4/issues/118</a><o:p></o:p></p>
<p>I am sure this worked when I tested but looking at it now I can see a couple of problems with it. Maybe this was down to a merge that went bad. Unfortunately, /cgi/set_lang was not part of my automated build testing prior to release but I will be adding
it when I next get a chance.<o:p></o:p></p>
<p>I have added a patch to the GitHub code that should fix the specific issue you reported:<o:p></o:p></p>
<p><a href="https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints3.4%2Fcommit%2F8c18cd49c65597539bd3fe9c1c97ef05c52694f7&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C5acd4f71cb754b1ad07608d92779f976%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637584227089345433%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=csnR1aVZu7PjbezVTSOOyOJ4VzwgniIrB4wwRw0SQXc%3D&reserved=0" originalSrc="https://github.com/eprints/eprints3.4/commit/8c18cd49c65597539bd3fe9c1c97ef05c52694f7" shash="y2CGxv41PaPqwT8S/w6NNPW1JqwwObCe7mf5ymu3XrKIe9mDyP+adwpfBsFczTYHuTCiDsVL5QYlFFo0uz+BzdfkikCUDWpWeGe8GAzWAVoiJNOxeJt7dMBUvYDNs/EZUz5dflsCZHHZAg1UeXbPZyuG2V+VWrlyNwnO9nZXJgE=">https://github.com/eprints/eprints3.4/commit/8c18cd49c65597539bd3fe9c1c97ef05c52694f7</a><o:p></o:p></p>
<p>However, to fix issue #118 you need to also make sure you have a recent version (I am on 4.51) of the CGI::Cookie Perl package installed, (i.e. most likely through installing using CPAN). Otherwise, this fix to set_lang will likely not do anything useful
(but should not make anything worse), as what it is trying to do is probably not supported by the version of CGI::Cookie you have installed.<o:p></o:p></p>
<p>Regards<o:p></o:p></p>
<p>David Newman<o:p></o:p></p>
<div>
<p class="MsoNormal">On 02/06/2021 17:18, Beaudoin, Mario via Eprints-tech wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div style="border:solid #8D3970 1.0pt;padding:9.0pt 9.0pt 9.0pt 9.0pt">
<p class="MsoNormal" style="line-height:16.5pt;background:#F7F9FA"><strong><span style="font-size:10.5pt;font-family:"Calibri",sans-serif;color:#8D3970;mso-fareast-language:FR-CA">CAUTION:</span></strong><span style="font-size:10.5pt;color:#8D3970;mso-fareast-language:FR-CA">
This e-mail originated outside the University of Southampton. <o:p></o:p></span></p>
</div>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Hello,</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">I just upgrade my dev repository on 3.4.1 to 3.4.3, and since I cannot change language with this code</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"><a href="{$config{https_root}}/cgi/set_lang?lang=fr">FRAN&#199;AIS</a></span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">I check the diff in file set_lang.pm with the 3.4.1 version and find that this piece of code does not work on my site
</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> if ( $session->{request}->scheme() eq "https" )</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> {</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> my $samesite = "None";</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> my $secure = 1;</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> my $httponly = 0;</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> }</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">If I comment this “if” loop everything work fine. The site is https all the time.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Any idea why this code does not work on my repository.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Thanks,</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><b><span style="font-size:12.0pt;mso-fareast-language:FR-CA">Mario Beaudoin</span></b><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif;mso-fareast-language:FR-CA"><br>
<br>
<o:p></o:p></span></p>
<pre>*** Options: <a href="http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech">http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech</a><o:p></o:p></pre>
<pre>*** Archive: <a href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.eprints.org%2Ftech.php%2F&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C5acd4f71cb754b1ad07608d92779f976%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637584227089345433%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=E4dHDvcVubgiW%2F8aOJQy%2FF7J2vgt06eIFVNUvWo2K3s%3D&reserved=0" originalSrc="http://www.eprints.org/tech.php/" shash="VargqHTEt5XpoxDAClL/NitF1AaZ9OuvqbXmUTjlRZgNIx5OHxyZ50bVFIzZAGzcKR9HN8WGga56NWyOnAicdUgMp9WBzz9lACPtEOAuSF5QtRqNqV8wMaeTnpGxLO6MehbCDjfFsjjrBOUg3SEy1oE6cJJHBK6Rzm6vEPNiV5o=">http://www.eprints.org/tech.php/</a><o:p></o:p></pre>
<pre>*** EPrints community wiki: <a href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwiki.eprints.org%2F&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C5acd4f71cb754b1ad07608d92779f976%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637584227089355389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fXoCP10xh%2FEU6t73SBkSmIcQI8psjWN8ggYNzlO%2Bo5c%3D&reserved=0" originalSrc="http://wiki.eprints.org/" shash="occqNT0IOU546DGcnxYE0rWXzDks/CwS5UCvnyuCBdtsSuormzlsmOCiKTs+2f1ZtLYSbztzrCFr4Xze9F83x1affp2qDKBIYPAig52hqwMzf/Ma5koTneVaSc0uRlWDDEf1kv7pDB89QXkwGL9rk/iBHZb1DVi4vwVRGTEyjlw=">http://wiki.eprints.org/</a><o:p></o:p></pre>
</blockquote>
<div id="DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2">
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif;mso-fareast-language:FR-CA"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="1" cellpadding="0" style="border:none;border-top:solid #D3D4DE 1.0pt">
<tbody>
<tr>
<td width="58" style="width:41.25pt;border:none;padding:9.75pt .75pt .75pt .75pt">
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif;mso-fareast-language:FR-CA"><a href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.avg.com%2Femail-signature%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign%3Dsig-email%26utm_content%3Demailclient&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C5acd4f71cb754b1ad07608d92779f976%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637584227089355389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=l1PP5rmXjbaZBbJZqg6bC%2B%2FEN%2BCwEQa%2F8tQvVnA8FmI%3D&reserved=0" originalSrc="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" shash="oP/lMHVfiQ+wCTK+iABSbqi8lzVPhWJAUOaL2t766hmStXVh7DYYrk+ds2r7otVfji0gPzbXuFzM6VlOfM/iVcufcfkp+kvJ8CGRjOmWMv2kCoaKRZZnffByZuQI6AJ5DAqSs4Bly2ZubVaXabbwR1/q6JKHzYajZa/TCgLcq/s=" target="_blank"><span style="border:solid windowtext 1.0pt;padding:0cm;text-decoration:none"><img border="0" width="46" height="29" style="width:.4791in;height:.302in" id="_x0000_i1025" src="cid:image001.jpg@01D75940.4B496840" alt="Image supprimée par l'expéditeur."></span></a><o:p></o:p></span></p>
</td>
<td width="473" style="width:352.5pt;border:none;padding:9.0pt .75pt .75pt .75pt">
<p class="MsoNormal" style="line-height:13.5pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#41424E;mso-fareast-language:FR-CA">Virus-free.
<a href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.avg.com%2Femail-signature%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign%3Dsig-email%26utm_content%3Demailclient&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C5acd4f71cb754b1ad07608d92779f976%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637584227089365345%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8vxAtz9PKoye4XBbyAuo1Qo35HX9XVy29sAwuMwZm0A%3D&reserved=0" originalSrc="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" shash="wHcac/hMADSQmyjFgGwsgIxwklE2ivbpzCWdqlCKseF60Wf3Le0K6VNTxxZf2V8cRjTpXp7fEmZNlMv56WZ5AELtO5DPm5BQm7aPqVha4pRnDC1T3IF2i4QTXGNvV/Np+8aOSj4Um5ZU14O66qzIvsJfHeeXeVxKXwJJRsHiGz8=" target="_blank">
<span style="color:#4453EA">www.avg.com</span></a> <o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif;mso-fareast-language:FR-CA"><o:p> </o:p></span></p>
</div>
</div>
</div>
</body>
</html>