<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body>
<p>Hi Mario,</p>
<p>This code relates to setting the correct attributes for the
cookie EPrints uses to store the user's language preference. This
change was made to deal with the fact that FireFox was not going
to continue to support the cookei for this in its current form. <br>
</p>
<p><a class="moz-txt-link-freetext" href="https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints3.4%2Fissues%2F118&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Cbe4755c93feb40360e6708d925eceb57%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637582521764287685%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3uExgxOT4DBifzOc%2FzvuS0Mu%2FA7GM0K6W2spHF7ZWZI%3D&reserved=0" originalSrc="https://github.com/eprints/eprints3.4/issues/118" shash="Hgbidc7+uu50jdY//fJdaZ8AZ821QHfwUmSER1TY0pY1moQ5Qd445fT5Ryqtfr4RAYI7dXufGuR3T0+cL8ntcVCRbF8vnb2ptCdjCYzPNjZCiP3GxZA1bN7fP6MDDiIVljFyE5vkL8PFV/gGdhUiSSl+50aJVXWdHXA8BuMCC20=">https://github.com/eprints/eprints3.4/issues/118</a><br>
</p>
<p>I am sure this worked when I tested but looking at it now I can
see a couple of problems with it. Maybe this was down to a merge
that went bad. Unfortunately, /cgi/set_lang was not part of my
automated build testing prior to release but I will be adding it
when I next get a chance.</p>
<p>I have added a patch to the GitHub code that should fix the
specific issue you reported:</p>
<p><a class="moz-txt-link-freetext" href="https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Feprints3.4%2Fcommit%2F8c18cd49c65597539bd3fe9c1c97ef05c52694f7&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Cbe4755c93feb40360e6708d925eceb57%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637582521764287685%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pYLAqScq5BeWmlKEF8Igj43cRdtY8zudltKk8onQ95E%3D&reserved=0" originalSrc="https://github.com/eprints/eprints3.4/commit/8c18cd49c65597539bd3fe9c1c97ef05c52694f7" shash="SAVYCCIPHLTiUwTHeqVDyo61H1bh1q7n0UQ4tuB98IZxUTimKfesg74K4pGY7T0K+IIxrZVgfT6SQk0OyYRb/IBNFnyzZFoKom0r7uZAwq4aOF2MJLvgJKvwGP5kq21UORVlKp+n04LeQzDqiHTWmOUAUBXC3l2/2Q/q4/WAaxA=">https://github.com/eprints/eprints3.4/commit/8c18cd49c65597539bd3fe9c1c97ef05c52694f7</a><br>
</p>
<p> However, to fix issue #118 you need to also make sure you have a
recent version (I am on 4.51) of the CGI::Cookie Perl package
installed, (i.e. most likely through installing using CPAN).
Otherwise, this fix to set_lang will likely not do anything useful
(but should not make anything worse), as what it is trying to do
is probably not supported by the version of CGI::Cookie you have
installed.<br>
</p>
<p>Regards</p>
<p>David Newman<br>
</p>
<div class="moz-cite-prefix">On 02/06/2021 17:18, Beaudoin, Mario
via Eprints-tech wrote:<br>
</div>
<blockquote type="cite" cite="mid:EMEW3|69326d103a251ac3488d5a262aa5a1e1x51HJF14eprints-tech-bounces|ecs.soton.ac.uk|YQXPR01MB3509E268DA95D7D56E3758D89D3D9@YQXPR01MB3509.CANPRD01.PROD.OUTLOOK.COM">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}div.WordSection1
{page:WordSection1;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div style="padding-bottom: 10px; padding-top: 5px;">
<div style="padding:12px; border:1px solid #8D3970;
background-color:#F7F9FA; color:#8D3970; font-size:14px;
line-height:22px; font-family: Calibri, Arial, Helvetica,
sans-serif;">
<strong>CAUTION:</strong> This e-mail originated outside the
University of Southampton.
</div>
</div>
<div>
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hello,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I just upgrade my dev
repository on 3.4.1 to 3.4.3, and since I cannot change
language with this code<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a
href="{$config{https_root}}/cgi/set_lang?lang=fr">FRAN&#199;AIS</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I check the diff in
file set_lang.pm with the 3.4.1 version and find that this
piece of code does not work on my site
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> if (
$session->{request}->scheme() eq "https" )<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">
my $samesite = "None";<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">
my $secure = 1;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">
my $httponly = 0;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">If I comment this “if”
loop everything work fine. The site is https all the
time.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Any idea why this code
does not work on my repository.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:12.0pt;mso-fareast-language:FR-CA">Mario
Beaudoin</span></b><span style="font-size:10.0pt;color:#1F497D;mso-fareast-language:FR-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">*** Options: <a class="moz-txt-link-freetext" href="http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech">http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech</a>
*** Archive: <a class="moz-txt-link-freetext" href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.eprints.org%2Ftech.php%2F&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Cbe4755c93feb40360e6708d925eceb57%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637582521764287685%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Eybv6SkILykgEnHbvgV42jL%2FGpTsgF6C%2FrbLRSjDYPI%3D&reserved=0" originalSrc="http://www.eprints.org/tech.php/" shash="a+io+QT+zww2MtXb65F5QZWFI+W/lWxgnygeLe+z4QAvV7RsWrDBkRkCv3DsNlcdYpmtsPsIJlfVJXEYdF9sIOTkQCh0OPZr4D7A8g7oJw6lEydgH0QnQ6wOBV8KwMlStUSk/NQIVOt3/AJJb+WIqahY34q2o2HDUrr8bHc44b0=">http://www.eprints.org/tech.php/</a>
*** EPrints community wiki: <a class="moz-txt-link-freetext" href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwiki.eprints.org%2F&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Cbe4755c93feb40360e6708d925eceb57%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637582521764297642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=4B0spRe8D%2BKwEcId8qtA2C9YZ2iJtn7m%2BZD0qBXHl%2FU%3D&reserved=0" originalSrc="http://wiki.eprints.org/" shash="J5q5USrnN53ltuxJpvuLOJ7x1Rxilv4Czq9Gl9hQr9DSK0v1+RrLmU4DKr0W0djA9muNC6ZNWvX0vdRClpBT/v6fGQ70aOnDAKidGBpUTz3VbH1tEPvfa9opWK+WO/DE0yyyC9wBrtMhUpiv3W2jdWY+z21f2kaPAj68nq/NEwE=">http://wiki.eprints.org/</a></pre>
</blockquote>
<div id="DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2"><br>
<table style="border-top: 1px solid #D3D4DE;">
<tr>
<td style="width: 55px; padding-top: 13px;"><a href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.avg.com%2Femail-signature%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign%3Dsig-email%26utm_content%3Demailclient&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Cbe4755c93feb40360e6708d925eceb57%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637582521764297642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=0RpCIpUuAXf%2BX2goWRmcNXsT%2FBLdh3DO3e9F2Fqmh9g%3D&reserved=0" originalSrc="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" shash="Hy+QdHxicmBs5pRUD3Ucps7TIHqpCbt3IYcjjAu8kUbXrz79by0HGmzxBhvarq/eoe4M/UWhNYgZRd/SCDAC1Ek8OHzTzxQwwgVWmMed4kHzZ1SdonX2TTudqYovp+tuNwRqgCwXRjD1JApcAKWpPOFN/hBFA2zZDWIGCpPcKgo=" target="_blank"><img src="https://ipmcdn.avast.com/images/icons/icon-envelope-tick-green-avg-v1.png" alt="" width="46" height="29" style="width: 46px; height: 29px;"></a></td>
<td style="width: 470px; padding-top: 12px; color: #41424e; font-size: 13px; font-family: Arial, Helvetica, sans-serif; line-height: 18px;">Virus-free. <a href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.avg.com%2Femail-signature%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign%3Dsig-email%26utm_content%3Demailclient&data=04%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7Cbe4755c93feb40360e6708d925eceb57%7C4a5378f929f44d3ebe89669d03ada9d8%7C0%7C0%7C637582521764307604%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=wCz6pkzj7r6Ln3wh87Y28Rj2eh4%2FGYlX9XgWOY3tQQY%3D&reserved=0" originalSrc="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" shash="l4EWT3n4eI2ihTr6QnGWiWJrFV/3asxAFFBszJOym/k7XylYxt+a30dRJr2+K9xKantGPIvsRf+Ezpk7KpR1BDPbvh2naIdhv3/zC+mKYOmlRVaySgXIj+i0jqx8+FOq/BD2xE0GOp7T3mrdqaE7Frh5Z0I2SvxZ+VkrYhlIYHY=" target="_blank" style="color: #4453ea;">www.avg.com</a>
</td>
</tr>
</table><a href="#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2" width="1" height="1"> </a></div></body>
</html>