<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Tahoma",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Tahoma",sans-serif;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Tahoma",sans-serif;
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Tahoma",sans-serif;
color:#1F497D;}
span.pl-k
{mso-style-name:pl-k;}
span.pl-c1
{mso-style-name:pl-c1;}
span.pl-smi
{mso-style-name:pl-smi;}
span.EmailStyle26
{mso-style-type:personal-compose;
font-family:"Tahoma",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-CA" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi David,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thank you! That is brilliant use of grep. Using this method, I was able to pinpoint the line, super helpful!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">We are on 3.3.12, but the problematic line comes from the orcid_support_advance plugin version 1.5.1 from the bazaar.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">It is this line:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Line 384: if( $old_c->{putcode} eq $new_c->{putcode} )<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">In this file: /cfg/cfg.d/z_orcid_support_advance.pl<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">That is actually line 384 in the default file from the bazaar:
</span><a href="https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbazaar.eprints.org%2F1138%2F1%2Fepm%2Forcid_support_advance%2Fcfg%2Fcfg.d%2Fz_orcid_support_advance.pl&data=01%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C6c505b2aaea14ff8784e08d825439424%7C4a5378f929f44d3ebe89669d03ada9d8%7C0&sdata=8gdz%2B0NQTPyTqeETuIw4uW9Y5VyNiN8ZN%2F62r%2F2y%2FVM%3D&reserved=0" originalSrc="https://bazaar.eprints.org/1138/1/epm/orcid_support_advance/cfg/cfg.d/z_orcid_support_advance.pl" shash="LRDvUTlh26zQ/u6mEBe6rmDZxEInIX4HmvKE6XlyEqLZQzPuHr+9MKNmOjlgE3HmiWWwTTPLFdMt5wr1l9WQDgyhS9lSb9z+HA3PzL60fPTTTsW2u4BThtLt7RF3wDqseNf67FPBzHiyowP/jMaKqmKAzuQ7MAhAyia7z3rf83A=">https://bazaar.eprints.org/1138/1/epm/orcid_support_advance/cfg/cfg.d/z_orcid_support_advance.pl</a><o:p></o:p></p>
<p class="MsoNormal">I see that this line is actually updated/fixed on GitHub, I guess it just didn’t make its way to the Bazaar yet?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">Line 384: </span><span class="pl-k"><span style="font-size:9.0pt;font-family:Consolas;color:#D73A49;background:white">if</span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">(
</span><span class="pl-c1"><span style="font-size:9.0pt;font-family:Consolas;color:#005CC5;background:white">defined</span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">
<span class="pl-smi">$old_c</span></span><span class="pl-k"><span style="font-size:9.0pt;font-family:Consolas;color:#D73A49;background:white">-></span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">{</span><span class="pl-c1"><span style="font-size:9.0pt;font-family:Consolas;color:#005CC5;background:white">putcode</span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">}
&& </span><span class="pl-c1"><span style="font-size:9.0pt;font-family:Consolas;color:#005CC5;background:white">defined</span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">
<span class="pl-smi">$new_c</span></span><span class="pl-k"><span style="font-size:9.0pt;font-family:Consolas;color:#D73A49;background:white">-></span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">{</span><span class="pl-c1"><span style="font-size:9.0pt;font-family:Consolas;color:#005CC5;background:white">putcode</span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">}
&& <span class="pl-smi">$old_c</span></span><span class="pl-k"><span style="font-size:9.0pt;font-family:Consolas;color:#D73A49;background:white">-></span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">{</span><span class="pl-c1"><span style="font-size:9.0pt;font-family:Consolas;color:#005CC5;background:white">putcode</span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">}
</span><span class="pl-c1"><span style="font-size:9.0pt;font-family:Consolas;color:#005CC5;background:white">eq</span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">
<span class="pl-smi">$new_c</span></span><span class="pl-k"><span style="font-size:9.0pt;font-family:Consolas;color:#D73A49;background:white">-></span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">{</span><span class="pl-c1"><span style="font-size:9.0pt;font-family:Consolas;color:#005CC5;background:white">putcode</span></span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white">}
)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;background:white"><o:p> </o:p></span></p>
<p class="MsoNormal"><a href="https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feprints%2Forcid_support_advance%2Fblob%2Fmaster%2Fcfg%2Fcfg.d%2Fz_orcid_support_advance.pl&data=01%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C6c505b2aaea14ff8784e08d825439424%7C4a5378f929f44d3ebe89669d03ada9d8%7C0&sdata=hlGd5kxbC7DJ%2FP1CmTiu0OuU%2FuCJ4v2CYtcvarTuqtQ%3D&reserved=0" originalSrc="https://github.com/eprints/orcid_support_advance/blob/master/cfg/cfg.d/z_orcid_support_advance.pl" shash="uBPIyao1zv426tVTg1yXV4PbbmRGJSb/3P5s0MGRNg3lYXptFd2Zd1bfB0FKCfPRam9xYHdVaWsdGleiLb94hA/D5z2bLzo5Ao8SwbMyIUmVD+qbEyiZNV/DlV8MZJRPnHCnTu3RkjiT/ZtI5WziucwA9gz0HK4s23E2+89CSxQ=">https://github.com/eprints/orcid_support_advance/blob/master/cfg/cfg.d/z_orcid_support_advance.pl</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I know I mentioned line 379, but that’s because I was testing on two different dev servers where that same line was in position 379 on a different server, but also being flagged on commit.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks again!<o:p></o:p></p>
<p class="MsoNormal">Tomasz<o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-family:"Calibri",sans-serif"> David R Newman <drn@ecs.soton.ac.uk>
<br>
<b>Sent:</b> July 10, 2020 6:13 PM<br>
<b>To:</b> eprints-tech@ecs.soton.ac.uk; Tomasz Neugebauer <Tomasz.Neugebauer@concordia.ca><br>
<b>Subject:</b> Re: [EP-tech] use of uninitialized value in string eq during eprint->commit<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p>Hi Tomasz,<o:p></o:p></p>
<p>I have do deal with these sorts of issues quite a lot. As you probably won't be surprised to hear, I do not know of the top of my head what is causing this issue. However, what typical I do is grep over the archive's cfg and possibly bin directories to
see if I can spot any code that may relate to this error. Using the following command you will find any code that could lead to that error on line 379:<o:p></o:p></p>
<p>grep -rn " eq " EPRINTS_PATH/archives/ARCHIVE_NAME/cfg/ EPRINTS_PATH/archives/ARCHIVE_NAME/bin/ | grep ":379:"<o:p></o:p></p>
<p>If you don't find anything then it may be worth having a look in perl_lib, lib, flavours/pub_lib. ingredients, site_lib etc. The reason for the "(eval 173)" is probably due to line 379 calling a user-defined function (sub).<o:p></o:p></p>
<p>If you can tell me the specific version of EPrints you are running I can probably have a look though the code codebase to give some suggestions. There is a good chance that line 379 will be in the core codebase and line 173 will be the line in the archive
level user-defined function.<o:p></o:p></p>
<p>Regards<o:p></o:p></p>
<p>David Newman<o:p></o:p></p>
<p><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 10/07/2020 23:01, Tomasz Neugebauer via Eprints-tech wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span lang="EN-US">I just finished a CLI script that updates some metadata field values in some items in my repository. Everything is working fine as far as I can tell, values get saved/updated, except that when I run the script, I get
this warning every time I do $eprint->commit:</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">“Use of uninitialized value in string eq at (eval 173) line 379.”</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Has anyone seen this before? It is rather cryptic and I can’t even tell what file it is referring to?</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Tomasz</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><br>
<br>
<o:p></o:p></span></p>
<pre>*** Options: <a href="http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech">http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech</a><o:p></o:p></pre>
<pre>*** Archive: <a href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.eprints.org%2Ftech.php%2F&data=01%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C6c505b2aaea14ff8784e08d825439424%7C4a5378f929f44d3ebe89669d03ada9d8%7C0&sdata=EMs%2BTHVvreMSjV9MDHXaqrQdNFgwiYzuhVAuJoGYLAY%3D&reserved=0" originalSrc="http://www.eprints.org/tech.php/" shash="i6Ch1CD9P3qzrYpfKfFdL1SFMnhItMTFnql/aLb/NOjTeJrCg9Sn0AJSFP0dyNXJTv+CHLmeffIDqMfqmbiep+68yjyC/gpCLBegzKto7mzdR8ZdTnJv17Zhe2Z8f3qXlbIAzysnpPJI2aDPeU8LFujv3kGYdLM0k43BI9XSsZM=">http://www.eprints.org/tech.php/</a><o:p></o:p></pre>
<pre>*** EPrints community wiki: <a href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwiki.eprints.org%2F&data=01%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C6c505b2aaea14ff8784e08d825439424%7C4a5378f929f44d3ebe89669d03ada9d8%7C0&sdata=RvlXTKgIzSaomas54lSkVOW52%2B4o60gyWJgSIzepGEw%3D&reserved=0" originalSrc="http://wiki.eprints.org/" shash="hOnHqBngk42y8vN85n1c+6BqibNOouqCIou1MXeV0/rb5wKe3r818W1kOl2KnNcTz49tQqLR/KWeOTu3QpeGh1CZG4m++3fmsm15lbUHmrhEFqtNfjHsGb42tH/xxHqz+sh9VQm+s7H3E5N0En+nE4yoDIervuhIlW4rnGAv0kk=">http://wiki.eprints.org/</a><o:p></o:p></pre>
</blockquote>
<div id="DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2">
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="1" cellpadding="0" style="border:none;border-top:solid #D3D4DE 1.0pt">
<tbody>
<tr>
<td width="58" style="width:41.25pt;border:none;padding:9.75pt .75pt .75pt .75pt">
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><a href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.avg.com%2Femail-signature%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign%3Dsig-email%26utm_content%3Demailclient&data=01%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C6c505b2aaea14ff8784e08d825439424%7C4a5378f929f44d3ebe89669d03ada9d8%7C0&sdata=As3fWQTqmBrzS37WQ7ecqDs9LgJvpxzViVtIHOuzVrY%3D&reserved=0" originalSrc="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" shash="Yg9ysgvz0RnVS09FVlKfTa3itkDA7IGdyv7aCQ14EBap1HQbbQUov8Z07wKrTnxYGCcYNJpvYi/DmQBcpR63xuylz1oyj47URfwZpsyH/v4ZPrM7hDKPfRQ+lAXA5Q4XLqwV1pXsw2+KzoaofeQDReoNxtgzm+3YkEVdt2DQqLA=" target="_blank"><span style="text-decoration:none"><img border="0" width="46" height="29" style="width:.4791in;height:.302in" id="_x0000_i1025" src="https://ipmcdn.avast.com/images/icons/icon-envelope-tick-green-avg-v1.png"></span></a><o:p></o:p></span></p>
</td>
<td width="473" style="width:352.5pt;border:none;padding:9.0pt .75pt .75pt .75pt">
<p class="MsoNormal" style="line-height:13.5pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#41424E">Virus-free.
<a href="https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.avg.com%2Femail-signature%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign%3Dsig-email%26utm_content%3Demailclient&data=01%7C01%7Ceprints-tech%40ecs.soton.ac.uk%7C6c505b2aaea14ff8784e08d825439424%7C4a5378f929f44d3ebe89669d03ada9d8%7C0&sdata=As3fWQTqmBrzS37WQ7ecqDs9LgJvpxzViVtIHOuzVrY%3D&reserved=0" originalSrc="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" shash="Yg9ysgvz0RnVS09FVlKfTa3itkDA7IGdyv7aCQ14EBap1HQbbQUov8Z07wKrTnxYGCcYNJpvYi/DmQBcpR63xuylz1oyj47URfwZpsyH/v4ZPrM7hDKPfRQ+lAXA5Q4XLqwV1pXsw2+KzoaofeQDReoNxtgzm+3YkEVdt2DQqLA=" target="_blank">
<span style="color:#4453EA">www.avg.com</span></a> <o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p>
</div>
</div>
</body>
</html>