Mark,<br><br>Thanks a lot for you help. I'll test it.<br><br>Regards,<br><br>Cristian<br><br><br><div class="gmail_quote">On Wed, Jun 13, 2012 at 10:28 PM, Mark Gregson <span dir="ltr"><<a href="mailto:mark.gregson@qut.edu.au" target="_blank">mark.gregson@qut.edu.au</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div link="blue" vlink="purple" lang="EN-AU"><div><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">Having looked a little deeper the problem in EPrints::Time::local_datetime() is the argument handling. This can be fixed by changing the following line:<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">my @t = localtime(@_ ? @_ : time());<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">to<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">my @t = localtime(@_ ? @_[0] : time());<u></u><u></u></span></p><p class="MsoNormal" style="margin-left:36pt">
<span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">Thanks to my colleague Matty who noticed that local_datetime() was acting like it had been passed ‘1’ as an argument.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">cheers<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">Mark<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></p>
<div><div style="border-width:1pt medium medium;border-style:solid none none;border-color:rgb(181,196,223) -moz-use-text-color -moz-use-text-color;padding:3pt 0cm 0cm"><p class="MsoNormal"><b><span style="font-size:10pt;font-family:"Tahoma","sans-serif"" lang="EN-US">From:</span></b><span style="font-size:10pt;font-family:"Tahoma","sans-serif"" lang="EN-US"> <a href="mailto:eprints-tech-bounces@ecs.soton.ac.uk" target="_blank">eprints-tech-bounces@ecs.soton.ac.uk</a> [mailto:<a href="mailto:eprints-tech-bounces@ecs.soton.ac.uk" target="_blank">eprints-tech-bounces@ecs.soton.ac.uk</a>] <b>On Behalf Of </b>Mark Gregson<br>
<b>Sent:</b> Thursday, 14 June 2012 10:10 AM<div><div class="h5"><br><b>To:</b> <a href="mailto:eprints-tech@ecs.soton.ac.uk" target="_blank">eprints-tech@ecs.soton.ac.uk</a><br><b>Subject:</b> [EP-tech] Re: Sitemap / time error<u></u><u></u></div>
</div></span></p></div></div><div><div class="h5"><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">Hi Cristian<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">The lastmod date in the sitemap index is set by this line: lastmod => sprintf( "%04d-%02d-%02d", EPrints::Time::get_date_array( time ) )<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">In 3.3 get_date_array() has been deprecated but for backwards compatibility calls local_datetime(). It looks like there is a bug in local_datetime(), or perhaps using it to provide backwards compatibility for get_date_array() is inappropriate, as it gives incorrect results:<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">print STDERR Dumper( get_date_array( time() ) ), "\n";<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">$VAR1 = '2012';<u></u><u></u></span></p><p class="MsoNormal" style="margin-left:36pt">
<span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">$VAR2 = '06';<u></u><u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">$VAR3 = '14';<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">print STDERR Dumper( local_datetime( time() ) ), "\n";<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">$VAR1 = 1970;<u></u><u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">$VAR2 = 1;<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">$VAR3 = 1;<u></u><u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">$VAR4 = 10;<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">$VAR5 = 0;<u></u><u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">$VAR6 = 1;<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">Until this is fixed you could paste the following into create_sitemap<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">sub get_date_array<u></u><u></u></span></p><p class="MsoNormal" style="margin-left:36pt">
<span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">{<u></u><u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"> my( $time ) = @_;<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"> $time = time unless defined $time;<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"> my @date = localtime( $time );<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"> return( <u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"> sprintf( "%02d", $date[5]+1900 ),<u></u><u></u></span></p><p class="MsoNormal" style="margin-left:36pt">
<span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"> sprintf( "%02d", $date[4]+1 ),<u></u><u></u></span></p><p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)"> sprintf( "%02d", $date[3] ) );<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt;font-family:"Courier New";color:rgb(31,73,125)">}<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">and remove the ‘EPrints::Time::’ from the line I included at the top so that this gets called instead of the broken EPrints method.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">Cheers<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">Mark<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)"><u></u> <u></u></span></p>
<div style="border-width:1pt medium medium;border-style:solid none none;border-color:rgb(181,196,223) -moz-use-text-color -moz-use-text-color;padding:3pt 0cm 0cm"><p class="MsoNormal"><b><span style="font-size:10pt;font-family:"Tahoma","sans-serif"" lang="EN-US">From:</span></b><span style="font-size:10pt;font-family:"Tahoma","sans-serif"" lang="EN-US"> <a href="mailto:eprints-tech-bounces@ecs.soton.ac.uk" target="_blank">eprints-tech-bounces@ecs.soton.ac.uk</a> [mailto:<a href="mailto:eprints-tech-bounces@ecs.soton.ac.uk" target="_blank">eprints-tech-bounces@ecs.soton.ac.uk</a>] <b>On Behalf Of </b>Centro de Documentación<br>
<b>Sent:</b> Wednesday, 13 June 2012 11:24 PM<br><b>To:</b> <a href="mailto:eprints-tech@ecs.soton.ac.uk" target="_blank">eprints-tech@ecs.soton.ac.uk</a><br><b>Subject:</b> [EP-tech] Re: Sitemap / time error<u></u><u></u></span></p>
</div><p class="MsoNormal"><u></u> <u></u></p></div></div><p class="MsoNormal" style="margin-bottom:12pt">Hi,</p><div><div class="h5"><br><br>I don't know why my sitemap.xml file shows this:<br><br><sitemapindex xsi:schemaLocation="<a href="http://www.sitemaps.org/schemas/sitemap/0.9" target="_blank">http://www.sitemaps.org/schemas/sitemap/0.9</a> <a href="http://www.sitemaps.org/schemas/sitemap/0.9/siteindex.xsd" target="_blank">http://www.sitemaps.org/schemas/sitemap/0.9/siteindex.xsd</a>"><br>
−<br><sitemap><br><loc><a href="http://nulan.mdp.edu.ar/sitemap-abstracts.xml.gz" target="_blank">http://nulan.mdp.edu.ar/sitemap-abstracts.xml.gz</a></loc><br><b><lastmod>1969-12-31</lastmod></b><br>
</sitemap><br></sitemapindex><br><br><br>The lastmod tag values inside sitemap-abstracts.xml.gz file are ok<u></u><u></u></div></div><div><div class="h5"><p class="MsoNormal"><span lang="EN-GB"><?xml version="1.0" encoding="UTF-8"?><urlset xmlns="<a href="http://www.sitemaps.org/schemas/sitemap/0.9" target="_blank">http://www.sitemaps.org/schemas/sitemap/0.9</a>" xmlns:xsi="<a href="http://www.w3.org/2001/XMLSchema-instance" target="_blank">http://www.w3.org/2001/XMLSchema-instance</a>" xsi:schemaLocation="<a href="http://www.sitemaps.org/schemas/sitemap/0.9" target="_blank">http://www.sitemaps.org/schemas/sitemap/0.9</a> <a href="http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd" target="_blank">http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd</a>"></span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-family:"Arial","sans-serif""><url><loc><a href="http://nulan.mdp.edu.ar/1/" target="_blank">http://nulan.mdp.edu.ar/1/</a></loc><b><lastmod>2011-11-08</lastmod></b><changefreq>yearly</changefreq><priority>1</priority></url><url><loc><a href="http://nulan.mdp.edu.ar/2/" target="_blank">http://nulan.mdp.edu.ar/2/</a></loc><b><lastmod>2011-04-12</lastmod></b><changefreq>yearly</changefreq><priority>1</priority></url><url><loc><a href="http://nulan.mdp.edu.ar/3/" target="_blank">http://nulan.mdp.edu.ar/3/</a></loc><b><lastmod>2011-04-12</lastmod></b><changefreq>yearly</changefreq><priority>1</priority></url></span><br>
.....<br><br>Any suggestion?<br><br>thanks,<br><br>Cristian<u></u><u></u></p></div></div></div></div><br>*** Options: <a href="http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech" target="_blank">http://mailman.ecs.soton.ac.uk/mailman/listinfo/eprints-tech</a><br>
*** Archive: <a href="http://www.eprints.org/tech.php/" target="_blank">http://www.eprints.org/tech.php/</a><br>
*** EPrints community wiki: <a href="http://wiki.eprints.org/" target="_blank">http://wiki.eprints.org/</a><br>
<br></blockquote></div><br>